Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 753 ReferredOutTests JSP component to React Component #786

Merged
merged 20 commits into from
Jun 25, 2024
Merged

fix 753 ReferredOutTests JSP component to React Component #786

merged 20 commits into from
Jun 25, 2024

Conversation

adityadeshlahre
Copy link
Contributor

@adityadeshlahre adityadeshlahre commented Mar 10, 2024 •
edited
Loading

fixing #753

Rewritten JSP component to React Component

Updated UI

image
image

Work In Progress 🙂

@adityadeshlahre
Copy link
Contributor Author

UI has been updated as requested 🙂
Searching based on that is also fixes !

image

@adityadeshlahre
Copy link
Contributor Author

Api End Points call fixed 🙂

This PR is ready for review 🚀 !
If any changes required let me know
Thank You

Work Flow Video Below 📹

refferedOut.mp4

@adityadeshlahre adityadeshlahre marked this pull request as ready for review March 17, 2024 14:24
@mozzy11
Copy link
Collaborator

mozzy11 commented Mar 18, 2024 •
edited
Loading

Thanks @adityadeshlahre for working on this issue.
Ideally we are not meant to redirect to the old UI to display the results.
You will need to re-write this controler to a REST controller so that the report can fetch the JSON data and render it in the react UI

mozzy11
mozzy11 requested changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@mozzy11 mozzy11 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The report data should be rendered in the react ui

@adityadeshlahre adityadeshlahre marked this pull request as draft March 19, 2024 09:59
@github-actions github-actions bot added the merge conflict Merge Conflicts label Mar 19, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @adityadeshlahre,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@mozzy11
Copy link
Collaborator

mozzy11 commented Mar 22, 2024

hello @adityadeshlahre , any progress here ??

@adityadeshlahre adityadeshlahre force-pushed the fix-753-referredOutTest-react branch from 34971a4 to 4819da5 Compare March 23, 2024 18:12
@adityadeshlahre
Copy link
Contributor Author

Hey @mozzy11 i have tried my best to get it done am not that proficient in JAVA Spring Web.

please let me know changes which are required

Thank You

@mozzy11
Copy link
Collaborator

mozzy11 commented Mar 25, 2024

@adityadeshlahre , can you attach a screenrecording of the new changes ??

@mozzy11
Copy link
Collaborator

mozzy11 commented Mar 25, 2024

can you resolve the merge conflicts and also Look into the CI build failre ??

@adityadeshlahre
Copy link
Contributor Author

@adityadeshlahre , can you attach a screenrecording of the new changes ??

restEndPoint.mp4

@mozzy11
Copy link
Collaborator

mozzy11 commented Mar 25, 2024 •
edited
Loading

@adityadeshlahre , can you now render the results in the react UI ??
see example in Audit Report

@github-actions github-actions bot removed the merge conflict Merge Conflicts label Mar 25, 2024
@adityadeshlahre
Copy link
Contributor Author

@adityadeshlahre , can you now render the results in the react UI ?? see example in Audit Report

image

I need to render patient info as [ title: refferoutpatientInfo] and which tests are being referred out right?

@adityadeshlahre
Copy link
Contributor Author

UPDATE : POST method working 🙂

postWorking.mp4

@adityadeshlahre adityadeshlahre force-pushed the fix-753-referredOutTest-react branch from 2f45e62 to 60dc81e Compare March 27, 2024 22:09
@github-actions GitHub Actions
Copy link

👋 Hi, @adityadeshlahre,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict Merge Conflicts label Mar 29, 2024
@mozzy11
Copy link
Collaborator

mozzy11 commented Apr 3, 2024

@adityadeshlahre see merge conflicts

@adityadeshlahre adityadeshlahre force-pushed the fix-753-referredOutTest-react branch from 3e2bb7f to 3c25cdc Compare April 3, 2024 16:59
@adityadeshlahre
Copy link
Contributor Author

@adityadeshlahre see merge conflicts

Hey @mozzy11 I have fixed merge conflicts!
Can you please provide the workflow of referredouttest jsp page which I need to implement in this PR 🙂
Thank You

@mozzy11
Copy link
Collaborator

mozzy11 commented Apr 3, 2024

Thanks @adityadeshlahre .
Can you first fix the CI build ??

@adityadeshlahre
Copy link
Contributor Author

Thanks @adityadeshlahre . Can you first fix the CI build ??

How can I do it sir 🙂 ?

@github-actions github-actions bot added merge conflict Merge Conflicts and removed merge conflict Merge Conflicts labels Apr 3, 2024
@mozzy11 mozzy11 changed the base branch from develop_3x to develop April 23, 2024 04:39
mozzy11
mozzy11 requested changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@mozzy11 mozzy11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adityadeshlahre ,
can you use carbon Grid and Colimn for the form layout and remove all custom css classes from the input elements

@github-actions github-actions bot removed the merge conflict Merge Conflicts label Jun 20, 2024
@adityadeshlahre adityadeshlahre force-pushed the fix-753-referredOutTest-react branch from 00980f7 to 89c107b Compare June 21, 2024 21:00
@adityadeshlahre
Copy link
Contributor Author

image

WILL FIX THE BUILD error in next commint

@adityadeshlahre adityadeshlahre marked this pull request as ready for review June 24, 2024 19:56
@adityadeshlahre adityadeshlahre force-pushed the fix-753-referredOutTest-react branch from a84f861 to 5cea902 Compare June 24, 2024 20:12
@mozzy11 mozzy11 merged commit 8ceab32 into I-TECH-UW:develop Jun 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalebSLane CalebSLane CalebSLane left review comments

@mozzy11 mozzy11 mozzy11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adityadeshlahre @mozzy11 @CalebSLane