(feat)add translations to reports module #611

jona42-ui · 2023-11-23T11:02:39Z

Objective

Add translations to report module

Screens

jona42-ui · 2023-11-23T11:05:11Z

mozzy11 · 2023-11-24T06:17:21Z

Thanks @jona42-ui .
can you attach the screenshots for translated pages for both languages?
Also, you don't need to include a default message as the translation logic already includes a default
message

ie instead of <FormattedMessage id="sidenav.label.statusreport" defaultMessage="Patient Status Report"/> ,
just do <FormattedMessage id="sidenav.label.statusreport"/>

jona42-ui · 2023-11-24T06:22:23Z

Thanks @jona42-ui . can you attach the screenshots for translated pages for both languages? Also, you don't need to include a default message as the translation logic already includes a default message

ie instead of <FormattedMessage id="sidenav.label.statusreport" defaultMessage="Patient Status Report"/> , just do <FormattedMessage id="sidenav.label.statusreport"/>

thanks @mozzy11
can you now look at the screen cast for both pages?
Sure, let me revert the default thing

jona42-ui · 2023-12-01T08:12:52Z

@mozzy11 what may be the cause of this, it consistently happens when I access the instance in the browser.

backend_logs.txt

mozzy11 · 2023-12-01T08:23:02Z

you seem to be having a corrupted db . clean your docker db volumes and start afresh . its caused by a liquibase error

jona42-ui · 2023-12-01T10:43:22Z

This has persisted am not sure how to get over this.
am not sure if its my machine with issues

jona42-ui · 2023-12-01T11:01:52Z

the error still persists, what i did was;
sudo docker-compose -f dev.docker-compose.yml down
then;
sudo docker volume rm openelis-global-2_db-data
then;

sudo docker-compose -f dev.docker-compose.yml up -d
just I got proxy issues and remapped these ports

mozzy11 · 2023-12-01T12:54:22Z

can we jump on a call

jona42-ui · 2023-12-01T14:38:05Z

sure
sorry i was off abit

jona42-ui · 2023-12-01T14:52:08Z

can we do on meet?
https://meet.google.com/fky-czvm-gia

jona42-ui · 2023-12-01T14:59:09Z

or we can schedule probably at a better time for you

jona42-ui · 2023-12-01T15:00:57Z

but I think you need to add me to the slack channel

jona42-ui · 2023-12-01T15:01:13Z

for better communication

mozzy11 · 2023-12-04T08:23:20Z

can you ping caesy on this thread

mozzy11 · 2023-12-04T08:23:59Z

can you also fix your merge conflicts ??

This reverts commit 1fc3394.

mozzy11 · 2023-12-04T09:18:58Z

are you there ??

jona42-ui · 2023-12-04T09:21:09Z

yes I am there @mozzy11

mozzy11 · 2023-12-04T09:21:17Z

were you able to run the setup ??

mozzy11 · 2023-12-04T09:22:27Z

can we have a quick call ??

jona42-ui · 2023-12-04T09:22:48Z

Yes i did when I sent the other PR but now its the same case

jona42-ui · 2023-12-04T09:23:02Z

its now failing again

mozzy11 · 2023-12-04T09:26:13Z

https://meet.google.com/usn-oziv-hsv

jona42-ui · 2023-12-04T13:37:06Z

cool on it. thanks *Sent with Right Inbox <https://www.rightinbox.com/?utm_source=signature>*

…

On Mon, Dec 4, 2023 at 4:33 PM Mutesasira Moses ***@***.***> wrote: hello @jona42-ui <https://github.com/jona42-ui> , i fixed the error. just pull the latest changes and try to run again — Reply to this email directly, view it on GitHub <#611 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASXUNGVL27JWQGWYB6WZT5TYHXGJTAVCNFSM6AAAAAA7XSSXO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZYGY2TGMJUG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

jona42-ui · 2023-12-04T14:11:28Z

hello @mozzy11 the logs show same errror with;

jona42-ui · 2023-12-04T14:15:48Z

its up now. all oaky after spinning up fresh containers

jona42-ui · 2023-12-04T14:32:04Z

though this PR is ready for review

jona42-ui · 2023-12-04T14:32:25Z

am just looking into another component

jona42-ui · 2023-12-04T14:54:31Z

Sorry i need to make more clean ups here

mozzy11 · 2023-12-04T14:57:51Z

can you also attach the screen shots ??

mozzy11 · 2023-12-05T19:30:14Z

@jona42-ui can you attach screen shots of both the pages you've added translations ??

jona42-ui · 2023-12-05T19:41:32Z

ooh! okay though basically it was menu items
I was wondering how to translate the forms/reports from the dynamically constructed URLs

mozzy11 · 2023-12-05T19:44:05Z

are you able to run openelis succesully ??

jona42-ui · 2023-12-05T19:44:37Z

yes its running successfully

mozzy11 · 2023-12-05T19:48:40Z

Alright , can you attach the screenshots of the translated pages ??

mozzy11 · 2023-12-05T19:50:26Z

was wondering how to translate the forms/reports from the dynamically constructed URLs

i ddnt get you comment above

jona42-ui · 2023-12-05T19:55:00Z

So, just to be sure am getting this well,, what is attached now above in the description is not what you expect?

mozzy11 · 2023-12-05T20:13:11Z

are those the updated screenshots that reflect your current changes ??

mozzy11 · 2023-12-05T20:18:54Z

are you done with any cleanups you wanted to do ??
ensure you update the screenshots that reflect your current changes

jona42-ui · 2023-12-05T20:32:55Z

alright @mozzy11 just winding up, will make sure all is up to date

jona42-ui · 2023-12-05T20:33:02Z

Thanks

jona42-ui · 2023-12-05T20:58:01Z

Updated!
@mozzy11

jona42-ui · 2023-12-05T21:01:48Z

As a follow up in another PR is translating this;

though I will need guidance on how!

jona42-ui · 2023-12-06T09:04:36Z

@mozzy11 does this align your expectations?

mozzy11 · 2023-12-06T09:08:41Z

frontend/src/components/Reports/Routine.js

      icon: IbmWatsonNaturalLanguageUnderstanding,
      SideNavMenuItem: [
        {
          link:
            config.serverBaseUrl +
            "/Report?type=indicator&report=activityReportByTest",
-          label: "By Test Type",
+          label: <FormattedMessage id="sideNav.label.bytesttype"/>,


did you just forget the english translation for this ??

mozzy11 · 2023-12-06T09:37:31Z

frontend/src/languages/en.json

@@ -179,6 +179,58 @@
    "sidenav.label.admin.organizationmgt" : "Organization Management" ,
    "sidenav.label.admin.usermgt" : "User Management",
    "sidenav.label.admin.labNumber" : "Lab Number Management",
+    "sidenav.title.statusreport":"Patient Status Report",
+    "sidenav.label.statusreport": "Patient Status Report",


you should avoid duplication of texts. just use a single text code for a similar text

my bad!
Thanks @mozzy11

jona42-ui added 2 commits November 23, 2023 13:58

add translations to reports

36714ba

Merge branch '2.8' into missingtranslations

fa64291

jona42-ui mentioned this pull request Nov 23, 2023

Add missing translation in the new React FrontEnd #585

Closed

cleanup

1fc3394

remove default message

3dbfe96

jona42-ui added 2 commits December 4, 2023 12:08

Revert "cleanup"

201a57f

This reverts commit 1fc3394.

clean up

bddb01a

Merge branch '2.8' into missingtranslations

bb572e8

clean up

33ce67f

clean up

0eb68a6

Merge branch '2.8' into missingtranslations

a3e9c2e

jona42-ui added 2 commits December 5, 2023 23:36

remove redundant code

dd42b1a

resolve accidental deletion

5650797

mozzy11 reviewed Dec 6, 2023

View reviewed changes

minor changes

a47b943

mozzy11 reviewed Dec 6, 2023

View reviewed changes

mozzy11 merged commit b9464b3 into I-TECH-UW:2.8 Dec 6, 2023
1 check passed

(feat)add translations to reports module #611

(feat)add translations to reports module #611

Conversation

jona42-ui commented Nov 23, 2023 • edited Loading

Objective

Screens

jona42-ui commented Nov 23, 2023

mozzy11 commented Nov 24, 2023 • edited Loading

jona42-ui commented Nov 24, 2023

jona42-ui commented Dec 1, 2023

mozzy11 commented Dec 1, 2023

jona42-ui commented Dec 1, 2023

jona42-ui commented Dec 1, 2023

mozzy11 commented Dec 1, 2023

jona42-ui commented Dec 1, 2023

jona42-ui commented Dec 1, 2023

jona42-ui commented Dec 1, 2023

jona42-ui commented Dec 1, 2023

jona42-ui commented Dec 1, 2023

mozzy11 commented Dec 4, 2023

mozzy11 commented Dec 4, 2023

mozzy11 commented Dec 4, 2023

jona42-ui commented Dec 4, 2023

mozzy11 commented Dec 4, 2023

mozzy11 commented Dec 4, 2023

jona42-ui commented Dec 4, 2023

jona42-ui commented Dec 4, 2023

mozzy11 commented Dec 4, 2023

jona42-ui commented Dec 4, 2023 via email

jona42-ui commented Dec 4, 2023

jona42-ui commented Dec 4, 2023

jona42-ui commented Dec 4, 2023 • edited Loading

jona42-ui commented Dec 4, 2023

jona42-ui commented Dec 4, 2023

mozzy11 commented Dec 4, 2023

mozzy11 commented Dec 5, 2023

jona42-ui commented Dec 5, 2023

mozzy11 commented Dec 5, 2023

jona42-ui commented Dec 5, 2023

mozzy11 commented Dec 5, 2023

mozzy11 commented Dec 5, 2023

jona42-ui commented Dec 5, 2023

mozzy11 commented Dec 5, 2023

mozzy11 commented Dec 5, 2023

jona42-ui commented Dec 5, 2023

jona42-ui commented Dec 5, 2023

jona42-ui commented Dec 5, 2023

jona42-ui commented Dec 5, 2023

jona42-ui commented Dec 6, 2023

mozzy11 Dec 6, 2023

Choose a reason for hiding this comment

mozzy11 Dec 6, 2023

Choose a reason for hiding this comment

jona42-ui Dec 6, 2023

Choose a reason for hiding this comment

jona42-ui commented Nov 23, 2023 •

edited

Loading

mozzy11 commented Nov 24, 2023 •

edited

Loading

jona42-ui commented Dec 4, 2023 •

edited

Loading