Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat)Add some missing translations to the cretaepatientform #595

Merged
merged 28 commits into from
Nov 22, 2023
Merged

(feat)Add some missing translations to the cretaepatientform #595

merged 28 commits into from
Nov 22, 2023

Conversation

jona42-ui
Copy link
Contributor

@jona42-ui jona42-ui commented Nov 16, 2023

Objective

Add traslations to the createpatient form

Issue

https://github.com/orgs/I-TECH-UW/projects/6/views/1?pane=issue&itemId=43998079

Screens

Before

Screencast.from.11-15-2023.06.04.46.PM.webm

After

Screencast.from.11-16-2023.08.22.42.AM.webm

@jona42-ui
Copy link
Contributor Author

@mozzy11
updated PR here

id={field.name}
className="inputText"
/>
<AccordionItem title={intl.formatMessage({ id: "emergencyContactInfo.title" })}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jona42-ui
Can you still get rid of the formatting changes here ??
its even wrong indentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay on it!

@mozzy11
Copy link
Collaborator

mozzy11 commented Nov 16, 2023

Thanks @jona42-ui . This looks better but you still have some formating changes some where .
can you also close the old PR ??

@jona42-ui
Copy link
Contributor Author

jona42-ui commented Nov 16, 2023 via email

@mozzy11
Copy link
Collaborator

mozzy11 commented Nov 16, 2023

Great , Looks clean now

@jona42-ui
Copy link
Contributor Author

@mozzy11 i will picking up another component unless you have any caveats!

@mozzy11 mozzy11 merged commit 334b3c4 into I-TECH-UW:2.8 Nov 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants