Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Tests for Adress Packge #1316

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

josephbate
Copy link
Contributor

Pull Requests Requirements

  • The PR title includes a brief description of the work done, including the
    Issue number if applicable.
  • The PR includes a video showing the changes for the work done.
  • The PR title follows conventional commit label standards.
  • The changes confirm to the OpenElis Global x3 Styleguide and design
    documentation.
  • The changes include tests or are validated by existing tests.
  • I have read and agree to the Contributing Guidelines of this project.

Summary

Added more tests for address package

Screenshots

[Add relevant screenshots here if applicable]

Related Issue

[Add a link to the related issue or mention it here if applicable]

Other

[Add any additional information or notes here]

@mherman22
Copy link
Contributor

can you close #1312 if you nolonger need it?

@mozzy11
Copy link
Collaborator

mozzy11 commented Nov 19, 2024

Thanks @mherman22 .
@josephbate can you look at the above comments ??

Copy link
Contributor

@mherman22 mherman22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @josephbate

@josephbate
Copy link
Contributor Author

LGTM, thanks @josephbate

thank you too

@github-actions github-actions bot added the merge conflict Merge Conflicts label Dec 16, 2024
Copy link

👋 Hi, @josephbate,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflict Merge Conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants