Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added sample service test class #1286

Merged

Conversation

josephbate
Copy link
Contributor

@josephbate josephbate commented Oct 28, 2024

Pull Requests Requirements

  • The PR title includes a brief description of the work done, including the
    Issue number if applicable.
  • The PR includes a video showing the changes for the work done.
  • The PR title follows conventional commit label standards.
  • The changes confirm to the OpenElis Global x3 Styleguide and design
    documentation.
  • The changes include tests or are validated by existing tests.
  • I have read and agree to the Contributing Guidelines of this project.

Summary

  • made changes to the sampleHumanDaoimpl to take in the id as a String which is in line with the data base
  • created the sam pleServiceTest class to hundle all intergrated test

Screenshots

[Add relevant screenshots here if applicable]

Related Issue

[Add a link to the related issue or mention it here if applicable]

Other

however there is a challenge i faced in getSamplesForPatient_shouldReturnSamplesForPatient() where database update operation violates foreign key constraints in both patient and SampleHuman tables which triggers the a PersistenceException is occurring due to a ConstraintViolationException.
could you please give me any Suggestion
here's link tothe error: https://pastebin.com/w0DDeLGD
Cc. @mozzy11
[Add any additional information or notes here]

@mozzy11
Copy link
Collaborator

mozzy11 commented Oct 28, 2024

@josephbate can you run mvn spotless:apply . the CI build fails because of formating error

@josephbate
Copy link
Contributor Author

@josephbate can you run mvn spotless:apply . the CI build fails because of formating error

Oh sorry
Let me fixed that quickly

@josephbate
Copy link
Contributor Author

hello moses think i have fixed it

@josephbate
Copy link
Contributor Author

ihave fixed it
please review it again
and also please adress my issue on the test case getSamplesForPatient_shouldReturnSamplesForPatient()
which i commented out

@mozzy11 mozzy11 merged commit dc1a0bb into I-TECH-UW:develop Oct 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants