-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#1005): Rewritten organization management page from JSP to React JS #1040
fix(#1005): Rewritten organization management page from JSP to React JS #1040
Conversation
thanks @adityadeshlahre for the great work,, |
these are the next & previous buttons to navigate through list!there CLIA number columndo you see the scroller bar at the lower part of video? |
...ain/java/org/openelisglobal/organization/controller/rest/OrganizationMenuRestController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openelisglobal/organization/controller/rest/OrganizationRestController.java
Show resolved
Hide resolved
👋 Hi, @adityadeshlahre, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
@adityadeshlahre, In addition to Cliff's question here. The rest controller implements paging. What that means is that it only sends 20 items on request which I guess are the ones we are able to see in the data table currently. However if you notice, the old ui shows that we have about 1000+ items in the db. Meaning we've to improve the pagination we currently have. So that when we click next page, we are sending something like |
Yes @mherman22 I know this is the edge case and will fix that in further commits. |
Thanks @adityadeshlahre . any blocker or progress ?? |
@mozzy11 its the POST mapping in the organization rest controller that is still not working as expected . The rest works fine |
576a17f
to
b383b56
Compare
b383b56
to
739ca49
Compare
thanks @adityadeshlahre,,just one more issue .... |
restController routes need to test it more
2a03e12
to
44e7034
Compare
fixes(#1005)
NOTE : will paste the video of workFlow later on
Pull Requests Requirements
Summary
rewritten Organization Management page in REACTJS
Screenshots
main page
add & modify org page [90% of its working and UI same]
[Add relevant screenshots here if applicable]
Related Issue
[Add a link to the related issue or mention it here if applicable]
Other
[Add any additional information or notes here]
If any changes required please let me know 🙂
Thank You