Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1005): Rewritten organization management page from JSP to React JS #1040

Conversation

adityadeshlahre
Copy link
Contributor

@adityadeshlahre adityadeshlahre commented May 11, 2024

fixes(#1005)

NOTE : will paste the video of workFlow later on

  • restController routes need to test it more
  • UI need to tested more
  • dataFetching for modify component need to be me more robust

Pull Requests Requirements

  • The PR title includes a brief description of the work done, including the Issue number if applicable.
  • The PR includes a video showing the changes for the work done.
  • The PR title follows conventional commit label standards.
  • The changes confirm to the OpenElis Global x3 Styleguide and design documentation.
  • The changes include tests or are validated by existing tests.
  • I have read and agree to the Contributing Guidelines of this project.

Summary

rewritten Organization Management page in REACTJS

Screenshots

main page

image

add & modify org page [90% of its working and UI same]

image

[Add relevant screenshots here if applicable]

Related Issue

[Add a link to the related issue or mention it here if applicable]

Other

[Add any additional information or notes here]

If any changes required please let me know 🙂

Thank You

@adityadeshlahre
Copy link
Contributor Author

@mozzy11 @gitcliff

workFlow video on REACT UI of Organization Management Page

workFlowOM

things left

  • Post requests
  • Save button fixes
  • sever more testing
  • few edge case need to fix

NOTE : IGNORE THOSE DEBUGGING BUTTONS, FOR NOW, WILL CLEAN IT UP LATER ON

Thank You 🙂
If any changes required please let me know !

@gitcliff
Copy link
Contributor

thanks @adityadeshlahre for the great work,,
would like to inquire on where the Previous and Next buttons are to switch from one page to another plus am also not seeing the CLIA Number columns as seen in the screenshot
Screenshot 2024-05-13 at 3 57 51 PM

@adityadeshlahre
Copy link
Contributor Author

thanks @adityadeshlahre for the great work,, would like to inquire on where the Previous and Next buttons are to switch from one page to another plus am also not seeing the CLIA Number columns as seen in the screenshot Screenshot 2024-05-13 at 3 57 51 PM

these are the next & previous buttons to navigate through list!

image

there CLIA number column

do you see the scroller bar at the lower part of video?
if you scroll through u will see it
By mistake, screenSize was too small that on recording that column did appear 🙂
image

@github-actions github-actions bot added the merge conflict Merge Conflicts label May 16, 2024
Copy link

👋 Hi, @adityadeshlahre,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@mherman22
Copy link
Contributor

mherman22 commented May 18, 2024

thanks @adityadeshlahre for the great work,, would like to inquire on where the Previous and Next buttons are to switch from one page to another plus am also not seeing the CLIA Number columns as seen in the screenshot Screenshot 2024-05-13 at 3 57 51 PM

@adityadeshlahre, In addition to Cliff's question here. The rest controller implements paging. What that means is that it only sends 20 items on request which I guess are the ones we are able to see in the data table currently. However if you notice, the old ui shows that we have about 1000+ items in the db.

Meaning we've to improve the pagination we currently have. So that when we click next page, we are sending something like organization?paging=2 in order to fetch the next page of 20 items to display in the data table🙂

@adityadeshlahre
Copy link
Contributor Author

thanks @adityadeshlahre for the great work,, would like to inquire on where the Previous and Next buttons are to switch from one page to another plus am also not seeing the CLIA Number columns as seen in the screenshot Screenshot 2024-05-13 at 3 57 51 PM

@adityadeshlahre, In addition to Cliff's question here. The rest controller implements paging. What that means is that it only sends 20 items on request which I guess are the ones we are able to see in the data table currently. However if you notice, the old ui shows that we have about 1000+ items in the db.

Meaning we've to improve the pagination we currently have. So that when we click next page, we are sending something like organization?paging=2 in order to fetch the next page of 20 items to display in the data table🙂

Yes @mherman22 I know this is the edge case and will fix that in further commits.

@mozzy11
Copy link
Collaborator

mozzy11 commented May 23, 2024

Thanks @adityadeshlahre . any blocker or progress ??

@gitcliff
Copy link
Contributor

Thanks @adityadeshlahre . any blocker or progress ??

@mozzy11 its the POST mapping in the organization rest controller that is still not working as expected . The rest works fine
cc @adityadeshlahre

@adityadeshlahre adityadeshlahre force-pushed the fix-1005-organization-management-page branch from 576a17f to b383b56 Compare June 7, 2024 17:16
@github-actions github-actions bot removed the merge conflict Merge Conflicts label Jun 10, 2024
@adityadeshlahre adityadeshlahre force-pushed the fix-1005-organization-management-page branch from b383b56 to 739ca49 Compare June 13, 2024 13:06
@adityadeshlahre
Copy link
Contributor Author

Organization Management WorkFlow

orgManagement.mp4

If any edge cases are found let me know 🙂
else this PR is ready to merge

Thank You

CC @mozzy11 & @gitcliff

@adityadeshlahre adityadeshlahre marked this pull request as ready for review June 13, 2024 21:52
@gitcliff
Copy link
Contributor

thanks @adityadeshlahre,,just one more issue ....
could you resolve the
Publish 3.X FrontEnd Docker image / build-and-push-image (pull_request) build failure , mya be you need to update the branch

@adityadeshlahre adityadeshlahre force-pushed the fix-1005-organization-management-page branch from 2a03e12 to 44e7034 Compare June 14, 2024 06:45
@mozzy11 mozzy11 merged commit b2ec5c7 into I-TECH-UW:develop Jun 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants