Use a single clamper for floats #4207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tybug
force-pushed
the
float-clamper
branch
2 times, most recently
from
b835247 to
843d540
Compare
tybug
commented
Dec 21, 2024
| } | ||
|
|
||
|
|
||
| def make_integer_kw(min_value, max_value, *, weights=None, shrink_towards=0): |
There was a problem hiding this comment.
Planned follow-up pull: use these convenience methods in tests! The space save of not specifying weights/shrink_towards/smallest_mag unless we care that it's non-default should be pretty solid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull changes the float clamper to directly incorporate float kwargs. While I think this approach is cleaner, I'm really doing it because it is easier to reuse the single clamper for future typed choice sequence work I have lined up.
Also removes a rule removed in new ruff versions to silence a warning, but we'll see if CI likes that 😄