Warn on @given + function-scoped fixtures
#2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
added
legibility
alexwlchan
reviewed
Feb 15, 2020
Zac-HD
force-pushed
the
fixture-scope-warning
branch
from
c4dc452
to
ddd072c
Compare
Function-scoped fixtures expect to be reset between every test, but this isn't the case between Hypothesis test cases - which will probably cause trouble.
Zac-HD
force-pushed
the
fixture-scope-warning
branch
from
ddd072c
to
be3f412
Compare
DRMacIver
approved these changes
Feb 29, 2020
|
I feel like this warning is probably too strict - I opened a discussion here: #2370 |
This was referenced Mar 20, 2020
|
Irrespective of whether this warning is too strict: what is the alternative of a function scoped fixture and could we get the warning message to reference the alternative? This in the line of thought: "Don't tell people what they shouldn't do, but what they should." |
MPvHarmelen
added a commit
to MPvHarmelen/hypothesis
that referenced
this pull request
Apr 5, 2020
Like this users will know what to do when getting this warning. See HypothesisWorks#2356.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #377 by automating our response of "don't do that then".
Skips the warning for
autouse=Truefixtures purely because it's usually much more difficult to fix those. For example you can have fixtures skip tests with a mark (and all@given()tests are markedhypothesisby our plugin), but this wouldn't support our own time-mocking system which inherits function-scoped-ness frommonkeypatchand should apply to@given()tests.So I'd call this two parts education, one part enforcement of good practice, and one part pragmatic non-enforcement.