Block install on Python < 3.5.2 #2321
Merged
+29
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @DRMacIver - the main decision here is whether we want keep any 3.5 at all, per #2218. |
alexwlchan
reviewed
Jan 20, 2020
Zac-HD
force-pushed
the
drop-python-351
branch
3 times, most recently
from
280f4d7 to
b16ecbd
Compare
We don't have a CI job for patch versions of Python 3.5, and I don't want to add one for the sake of ugly workarounds on an old Python we're dropping soon anyway.
Zac-HD
force-pushed
the
drop-python-351
branch
from
b16ecbd to
38cdc06
Compare
alexwlchan
approved these changes
Jan 28, 2020
|
Thanks @alexwlchan - I always really appreciate your reviews 😍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is designed to prevent problems like #2318 - in #2315 I tried to to add a CI job for Python 3.5.1, but it turns out that
toxdoesn't support patch versions... and so I thought the best option was to explicitly drop 3.5.0 and 3.5.1 and get ahead of the cleanups.We're not the only project to be thinking about this: e.g. there's pytest-dev/pytest#6470, python-trio/trio#880, and python/mypy#7420. Ubuntu has shipped Python >= 3.5.2 since their 16.04.05, and PyPI stats show low 3.5 usage (much lower than 2.7), of which we think only a small portion will be affected.