-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for positional only arguments #1944
Conversation
Thanks @pganssle - this looks great to me! Three things before I can merge this:
Then I'll merge ASAP - and hope to see you at PyCon! |
Sure thing. I can do that in an hour or so. This is also slightly tricky because it will break anyone testing with earlier alpha releases that don't include PEP 570. If that's not a concern we can leave as is, but if it is a concern, I can try and come up with a way to detec PEP 570 support and guard on that. |
I'd prefer to keep it as simple as possible, so this form looks great 😄 (plus the string formatting thing noted above) |
Hm.. I'll rebase this once the previous release is done. I guess that's a problem with this system of "every PR triggers a release" (though presumably just a problem until the release bot or whatever removes |
Yep, sorry about that! Just a ~15 minute window where pushes get merge conflicts. We've looked at a bors-like system but haven't quite needed it yet... though it would help at sprints. |
PEP 570 adds "positional only" arguments to Python, which changes the code object constructor. This adds support for Python 3.8. Fixes GH HypothesisWorks#1943: HypothesisWorks#1943
Thanks @Zac-HD, see you at PyCon! |
PEP 570 adds "positional only" arguments to Python, which changes the
code object constructor. This adds support for Python 3.8.
I assume this is covered by existing tests, but it would be good to add a "nightly" build to the CI matrix.
Fixes #1943