-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Afford Submission visibility settings per Group #3959
base: main
Are you sure you want to change the base?
Afford Submission visibility settings per Group #3959
Conversation
849595b
to
5a71f9f
Compare
c3ede29
to
05980f5
Compare
Edit: oh, I see it. Fixed and pushed. |
763a179
to
0ac715e
Compare
@theskumar Is there anything else we need to do on this one? |
@bickelj Looks like you got a merge conflict. |
Administrators can see "Related submissions" on a Submissions Details page. This change allows a Wagtail administrator to add visibility to any Group such that members of the Group can also see "Related submissions." This change embraces Django Group and Wagtail Setting Models such that the settings can be made within the application. A Wagtail administrator can add visibility from the `admin` interface via Settings -> Submission Details Page Settings. To grant visibility, the administrator checks the "Sees related submissions" box for the Group specified in the Group dropdown. To revoke visibility, the administrator unchecks the same. However, if a user is a member of any group that has been granted visibility, the user will have visibility. Fixes HyphaApp#3958
0ac715e
to
ce9f737
Compare
@frjo If wagtail admin only affects wagtail admin, does that mean wagtail admin is superfluous since it doesn't affect the rest of the app? I'm trying to understand the goal of the boundaries around wagtail admin. I would guess that this PR does not match your expectation for use of wagtail admin. But I still think it is useful for wagtail administrators (as opposed to developers or system administrators) to be able to set up some permissions and visibility somewhere. Until that somewhere exists, wouldn't it be good to have this? |
In Wagtail admin you create funds/labs/forms, make settings etc. Wagtail admin permissions control who can make these things. Hypha permissions control who can create/edit/view/review submissions/projects/invoices/reports etc. This PR contains a specific permission, for a specific block on a specific view. A narrow usecase I think. |
Administrators can see "Related submissions" on a Submissions Details page. This change allows a Wagtail administrator to add visibility to any Group such that members of the Group can also see "Related submissions." This change embraces Django Group and Wagtail Setting Models such that the settings can be made within the application.
A Wagtail administrator can add visibility from the
admin
interface via Settings -> Submission Details Page Settings. To grant visibility, the administrator checks the "Sees related submissions" box for the Group specified in the Group dropdown. To revoke visibility, the administrator unchecks the same. However, if a user is a member of any group that has been granted visibility, the user will have visibility.Fixes #3958
Test Steps
Using the sandbox database.
apply/submissions/2/
)/admin
)admin/settings/apply_utils/submissionsdetailssetting/
)