Add Organization Name Column #3295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frjo
added
Type: Enhancement
frjo
requested changes
Mar 21, 2023
|
I don't think this needs a migration. At least, it works for me without one (and there's none on our original changes). |
|
@frankduncan Hypha CI and my local environment both claims migration is needed. Se failed tests below. |
frankduncan
force-pushed
the
enhancement/gh-3290-add-organization-name-column
branch
from
eb49df7
to
27c0251
Compare
|
Migration added, though interesting that it didn't seem to be required for the feature to work for me. Hopefully the CI will be happy with the changes :) |
frjo
approved these changes
Mar 23, 2023
… the application detail view
frjo
force-pushed
the
enhancement/gh-3290-add-organization-name-column
branch
from
27c0251
to
c9286ae
Compare
fourthletter
added
Status: Tested - approved for live ✅
and removed
Status: Needs testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3290
Adds an organization name column to the submission table. To effect that change, a new unique block needed to be added. I did test that the column will not show up when added to
SUBSMISSION_TABLE_EXCLUDED_FIELDS