Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FW-98] PWM Tests #462

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

[FW-98] PWM Tests #462

wants to merge 3 commits into from
+114 −12

Conversation

jdmarmen
Copy link
Contributor

  • Small changes in set_dead_time to ensure that we can only set the dead_time if the PWM is off.
  • Added PWM tests

gonzalo-sm
gonzalo-sm approved these changes Nov 19, 2024
View reviewed changes
Copy link

@gonzalo-sm gonzalo-sm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this trigger an ErrorHandler? because I dont see a pin map in this PR defining the map with available_pwms

gonzalo-sm
gonzalo-sm suggested changes Nov 19, 2024
View reviewed changes
Copy link

@gonzalo-sm gonzalo-sm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm disapproving it, Check ErrorHandler is not triggered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gonzalo-sm gonzalo-sm gonzalo-sm requested changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdmarmen @gonzalo-sm