Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW-94] Changes in ADC + included tests #461

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

jdmarmen
Copy link
Contributor

  • Changes in ADC:
  1. The original implementation wasn't accessing the pins memory location, it was creating a copy. Changed the implementation to work with pointers.
  2. Added the pin type selection inside inscribe(), as it wasn't done.
  3. Added a map to pair each ADC pin ID with it's corresponding pin.
  4. More changes on inscribe() start() and get_value_pointer() to support the new implementation.
  5. Small changes on SharedMemory::get_pin().
  • Added ADC tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants