Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove view recalc queue #2203

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lampajr
Copy link
Member

@lampajr lampajr commented Dec 6, 2024

Followup pull request of #2202

This is not meant to be backported.

Fixes #2220

Changes proposed

Move the dataset_view update logic from db to Horreum java logic.

As part of this refactoring the following entities have been removed:

  • Tables

    • view_recalc_queue and:
  • Triggers

    • dsv_after_delete
    • dsv_after_update
    • recalc_dataset_view
    • dsv_after_insert
  • Functions:

    • dsv_after_vc_delete_func
    • dsv_after_vc_update_func
    • recalc_dataset_view
    • dsv_after_lv_insert_func

Moreover the calc_dataset_view(datasetId bigint, viewId bigint DEFAULT NULL) signature has changed
such that it can be called in two different scenarios, i.e., by dataset or by dataset-view.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@lampajr lampajr force-pushed the remove_view_recalc_queue branch 2 times, most recently from acba64d to 7f2ba80 Compare December 9, 2024 11:48
As part of this refactoring I removed table
view_recalc_queue and:

Triggers
- dsv_after_delete
- dsv_after_update
- recalc_dataset_view
- dsv_after_insert

Functions:
- dsv_after_vc_delete_func
- dsv_after_vc_update_func
- recalc_dataset_view
- dsv_after_lv_insert_func

Signed-off-by: Andrea Lamparelli <[email protected]>
@lampajr lampajr force-pushed the remove_view_recalc_queue branch from 7f2ba80 to 2d30094 Compare December 16, 2024 08:29
@lampajr lampajr marked this pull request as ready for review December 16, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove view_recalc_queue and related triggers
1 participant