Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasets listing should treat {} as empty filter #2162

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

lampajr
Copy link
Member

@lampajr lampajr commented Nov 6, 2024

Changes proposed

Early improvement that would consider {} as empty filter, this way the query is a LOT easier and faster.

This does not solve the performance issue we currently have when the filter is set, as it would require a refactoring that might be not necessarily as we are trying to get rid of the datasets entirely.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

Copy link
Member

@johnaohara johnaohara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnaohara johnaohara merged commit 9ba5fc2 into Hyperfoil:master Nov 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants