Remove test token feature #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barreiro
commented
Oct 18, 2024
horreum-api/src/main/java/io/hyperfoil/tools/horreum/api/services/RunService.java
Show resolved
Hide resolved
lampajr
requested changes
Oct 21, 2024
There was a problem hiding this comment.
Overall looks good to me but I'd update the documentation accordingly, i.e., removing any mention to the Horreum token like https://horreum.hyperfoil.io/docs/tasks/upload-run/#getting-horreum-token and adding a new migration guide (even very simple) clearly stating out to migrate from Horreum token to the API token approach.
horreum-api/src/main/java/io/hyperfoil/tools/horreum/api/services/RunService.java
Show resolved
Hide resolved
johnaohara
requested changes
Oct 21, 2024
horreum-api/src/main/java/io/hyperfoil/tools/horreum/api/services/RunService.java
Show resolved
Hide resolved
horreum-api/src/main/java/io/hyperfoil/tools/horreum/api/services/TestService.java
Outdated
Show resolved
Hide resolved
horreum-backend/src/main/java/io/hyperfoil/tools/horreum/server/EncryptionManager.java
Show resolved
Hide resolved
horreum-backend/src/main/java/io/hyperfoil/tools/horreum/svc/RunServiceImpl.java
Outdated
Show resolved
Hide resolved
horreum-backend/src/main/java/io/hyperfoil/tools/horreum/svc/RunServiceImpl.java
Outdated
Show resolved
Hide resolved
horreum-backend/src/main/java/io/hyperfoil/tools/horreum/svc/TestServiceImpl.java
Outdated
Show resolved
Hide resolved
horreum-backend/src/main/java/io/hyperfoil/tools/horreum/svc/TestServiceImpl.java
Show resolved
Hide resolved
horreum-backend/src/test/java/io/hyperfoil/tools/horreum/svc/BaseServiceTest.java
Show resolved
Hide resolved
horreum-backend/src/test/java/io/hyperfoil/tools/horreum/svc/RunServiceTest.java
Show resolved
Hide resolved
johnaohara
approved these changes
Nov 4, 2024
I have opened #2154 to track the guide |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The introduction of API keys (#1952) as an alternative authentication mechanism makes the test tokens redundant.
We're now at a point when that feature can be removed.