Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mtc: Optimal frequency regression #136

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

maxguy2001
Copy link
Member

Implement linear regression to calculate coefficients for f-v curve

src/propulsion/rpm_regulator.cpp Outdated Show resolved Hide resolved
src/utils/math/regression.hpp Outdated Show resolved Hide resolved

class Regression {
public:
Regression();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this setup. I may rewrite it for times sake.

 comment out function calls until class properly defined
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2022

Codecov Report

Merging #136 (56f86c1) into master (b4144b8) will decrease coverage by 0.26%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   34.01%   33.75%   -0.27%     
==========================================
  Files          67       68       +1     
  Lines        3545     3573      +28     
==========================================
  Hits         1206     1206              
- Misses       2339     2367      +28     
Impacted Files Coverage Δ
src/propulsion/main.cpp 19.35% <0.00%> (-2.47%) ⬇️
src/propulsion/rpm_regulator.cpp 0.00% <0.00%> (ø)
src/utils/io/spi.cpp 0.00% <ø> (ø)
src/utils/math/regression.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4144b8...56f86c1. Read the comment docs.

@maxguy2001 maxguy2001 marked this pull request as ready for review May 22, 2022 04:54
@maxguy2001 maxguy2001 requested a review from mifrandir May 22, 2022 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Motor f-v curve fitting and initialisation checks
3 participants