Add Typescript typing #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 3, 2017 18:30
|
Hi @HurricaneJames, do you have any concerns or feedback with this? |
technicallyfeasible
approved these changes
Feb 7, 2018
|
Any updates on this? Trying to use TypeScript with this project myself, and while I could just do the same as this PR does in a local file, I'd rather see it just be there in the main one. Just realized this project actually looks pretty dead - last update was years ago. :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for writing this useful validators.
To make them even more useful when working with TypeScript or VS Code it would be great to additionally have type completion.
I have added a Type Definition file to get autocompletion and TypeChecks (and some Tests for it). It would be great if you could release them with the npm package.