Don't call getPropType until error detected as it is slow for large d…

…ata structures
HurricaneJames · May 22, 2016 · 9bbb3be · 9bbb3be
1 parent 0ec415e
commit 9bbb3be
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/ImmutablePropTypes.js b/src/ImmutablePropTypes.js
@@ -149,8 +149,8 @@ function createIterableOfTypeChecker(typeChecker) {
 function createRecordOfTypeChecker(recordKeys) {
   function validate(props, propName, componentName, location, propFullName) {
     var propValue = props[propName];
-    var propType = getPropType(propValue);
     if (!(propValue instanceof Immutable.Record)) {
+      var propType = getPropType(propValue);
       var locationName = location;
       return new Error(
         `Invalid ${locationName} \`${propFullName}\` of type \`${propType}\` ` +
@@ -176,8 +176,8 @@ function createRecordOfTypeChecker(recordKeys) {
 function createShapeTypeChecker(shapeTypes, immutableClassName = 'Iterable', immutableClassTypeValidator = Immutable.Iterable.isIterable) {
   function validate(props, propName, componentName, location, propFullName) {
     var propValue = props[propName];
-    var propType = getPropType(propValue);
     if (!immutableClassTypeValidator(propValue)) {
+      var propType = getPropType(propValue);
       var locationName = location;
       return new Error(
         `Invalid ${locationName} \`${propFullName}\` of type \`${propType}\` ` +