Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs blank strings and "Ex" #982

Merged
merged 3 commits into from
Sep 26, 2020
Merged

Fix bugs blank strings and "Ex" #982

merged 3 commits into from
Sep 26, 2020

Conversation

mr-aboutin
Copy link
Contributor

Added exception for word "Ex" to "Exes"

fixes #975

Here is a checklist you should tick through before submitting a pull request:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No ReSharper warnings
  • There is proper unit test coverage
  • N/A If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • N/A Xml documentation is added/updated for the addition/change
  • Your PR is (re)based on top of the latest commits from the dev branch (more info below)
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • N/A Readme is updated if you change an existing feature or add a new one
  • Run either build.cmd or build.ps1 and ensure there are no test failures

Added exception for word "Ex" to "Exes"
@dnfadmin
Copy link

dnfadmin commented Sep 25, 2020

CLA assistant check
All CLA requirements met.

@mr-aboutin mr-aboutin changed the title Added check for Blank string Fix bugs blank strings and "Ex" Sep 26, 2020
blank return blank to avoid NullPointer
@clairernovotny clairernovotny merged commit 28b1252 into Humanizr:master Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

General Bugs Found
3 participants