Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement sv (Swedish/Sweden) for Number to Word #856

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

haf
Copy link
Contributor

@haf haf commented Sep 27, 2019

Here is a checklist you should tick through before submitting a pull request:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No ReSharper warnings
  • There is proper unit test coverage
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • There are very few or no comments (because comments shouldn't be needed if you write clean code — this justification is wrong, they are still needed. Perhaps you've never worked with someone who's articulate.)
  • Xml documentation is added/updated for the addition/change — not really
  • Your PR is (re)based on top of the latest commits from the dev branch (more info below) — there's no dev branch in origin.
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one — not applicable
  • Run either build.cmd or build.ps1 and ensure there are no test failures — no can do, I'm on macOS

Fixes #857

@dnfclas
Copy link

dnfclas commented Sep 27, 2019

CLA assistant check
All CLA requirements met.

@haf haf force-pushed the f/sv-number-to-words branch from 34f22c2 to 0dbc92f Compare September 27, 2019 12:46
@clairernovotny clairernovotny merged commit a02413a into Humanizr:master Sep 27, 2019
@clairernovotny
Copy link
Member

Thanks!

@haf
Copy link
Contributor Author

haf commented Sep 27, 2019

You're welcome!

@haf haf deleted the f/sv-number-to-words branch September 27, 2019 13:01
@haf
Copy link
Contributor Author

haf commented Sep 27, 2019

When do you think you can release this as a nuget?

@clairernovotny
Copy link
Member

2.7.9 is rolling out to NuGet now...probably 15 min to an hour for NuGet "indexing" for it to show up.

@haf
Copy link
Contributor Author

haf commented Sep 28, 2019

Sweet! 🧨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swedish Number to Word doesn't exist
3 participants