Change Pascalize to remove spaces fix #774 #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Overall this change is fine, but something seems to have gotten messed up with the readme diff? |
Fix readme
|
Not sure what happened there, think I've fixed it and updated the branch |
|
The latest commits remove the second regex line (it wasn't actually needed), and also add support for multiple spaces in a row. Not sure what the thoughts are on adding support for multiple underscores in a row? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to change to fix #774 that changes Pascalize (and therefore Camelize too) to treat spaces in the same way it treats underscores.
I wasn't sure whether to have this as an optional change, or a change to the method itself, so I've chosen to just change the method and create this PR as a way to generate conversation around the issue.
Let me know if you have any thoughts.