Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arabic formatter and Arabic TimeSpan and Date localization for multiple units #55

Merged
merged 4 commits into from
Jan 9, 2014

Conversation

harouny
Copy link
Contributor

@harouny harouny commented Jan 7, 2014

No description provided.

@MehdiK
Copy link
Member

MehdiK commented Jan 7, 2014

Awesome. Thanks for the much needed work.

There were a few minor things I commented on that I would appreciate if you could add to your PR.

@harouny
Copy link
Contributor Author

harouny commented Jan 9, 2014

Done

@MehdiK
Copy link
Member

MehdiK commented Jan 9, 2014

Thanks a lot for this. This has to be the most complex translation I've had so far. Very cool :)

I left you a few comments on some of the translations which display a bit weird. Not sure if it's lack of proper unicode support or if the actual translation has some issues. I am going to merge this; but I would appreciate if you could please review the translations again and fix any potential issues.

MehdiK added a commit that referenced this pull request Jan 9, 2014
Add Arabic formatter and Arabic TimeSpan and Date localization for multiple units
@MehdiK MehdiK merged commit 03d6497 into Humanizr:master Jan 9, 2014
@harouny
Copy link
Contributor Author

harouny commented Jan 9, 2014

Yeah working with Arabic is cool :)
Don't worry about those they are just Github display issues...(I explained above)

@MehdiK
Copy link
Member

MehdiK commented Jan 14, 2014

This is now available on NuGet. Thanks.

@harouny
Copy link
Contributor Author

harouny commented Jan 15, 2014

Coool, you are welcome mate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants