Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow formatted byte size when humanizing ByteRate #517

Merged
merged 3 commits into from
Jan 30, 2016

Conversation

ronnieoverby
Copy link

I have needed this on more than one occasion and have had to resort to not using ByteRate because I couldn't format the byte size part of the string.

@mexx
Copy link
Collaborator

mexx commented Jan 29, 2016

@ronnieoverby Thank you for your contribution.
Please take a look at the contribution guideline.

The build is failing, could you please fix it.
Please update the readme.md with the extended functionality.

@ronnieoverby
Copy link
Author

I've updated the readme. I'm not sure how I can fix the failing build, though. It seems to be failing when verifying the public api didn't change. I added an overload and didn't change the public api.

Can you help me out? @mexx

@mexx
Copy link
Collaborator

mexx commented Jan 29, 2016

Sure, as you figured out, it fails on public api verification. The public api consist of every publicly available type, method signature and property.
The added overload is part of the public api. You have to update the approve_public_api.approved.txt

@ronnieoverby
Copy link
Author

Thanks, I didn't realize I had to update that file. For some reason, I was
thinking that the api approver was making sure I didn't remove/change
existing signatures only. I'll give it another shot.

On Fri, Jan 29, 2016 at 3:47 PM, Max Malook [email protected]
wrote:

Sure, as you figured out, it fails on public api verification. The public
api consist of every publicly available type, method signature and property.
The added overload is part of the public api. You have to update the
approve_public_api.approved.txt
https://github.com/Humanizr/Humanizer/blob/dev/src/Humanizer.Tests/ApiApprover/PublicApiApprovalTest.approve_public_api.approved.txt


Reply to this email directly or view it on GitHub
#517 (comment).

@ronnieoverby
Copy link
Author

woohoo

clairernovotny pushed a commit that referenced this pull request Jan 30, 2016
allow formatted byte size when humanizing ByteRate
@clairernovotny clairernovotny merged commit 99500a7 into Humanizr:dev Jan 30, 2016
@clairernovotny
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants