Use collection formatter when humanizing timespans. Fixes #497 #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code looks good to me. If one would love to have the standard collection format behavior, she can send We can look at the defaults and making breaking when the discussion of global config design in #508 comes to a conclusion and the new way of doing things is clear, what do you think? |
ErikSchierboom
force-pushed
the
customize-list-timespans
branch
from
3623e5b
to
f7337b7
Compare
|
@mexx I have made the requested change, making this PR non-breaking. |
|
Sorry, but there is one more thing. Please document this parameter in the readme.md |
ErikSchierboom
force-pushed
the
customize-list-timespans
branch
from
f7337b7
to
ab8c2ff
Compare
|
@mexx The |
|
LGTM, @onovotny do you mind to merge it? |
clairernovotny
pushed a commit
that referenced
this pull request
Jan 19, 2016
Use collection formatter when humanizing timespans. Fixes #497
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.