Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DateTime and TimeSpan humanization to use ToQuantity extension #205 #405

Closed
wants to merge 9 commits into from

Conversation

alimeziane
Copy link

I have add ShowQuantityAs option to timeSpan and DateTime humanization.

@alimeziane
Copy link
Author

I added to TimeSpan and DateTime humanization the ability to choose using ShowQuantityAs display amounts by number or letter. My development is based on the existing features of ToWords() to avoid redudancies.
For example :
TimeSpan.FromDays(15).Humanize(2,showQuantityAs : ShowQuantityAs.Words) --> two weeks , one day
DateTime.Now.AddDays(12).Humanize(false,showQuantityAs : ShowQuantityAs.Words) --> twelve days from now

@clairernovotny
Copy link
Member

What is the current status of this? Is it feature complete?

@clairernovotny
Copy link
Member

Ping?

@MehdiK
Copy link
Member

MehdiK commented Nov 4, 2017

This PR has been sitting here for 2.5 years with no updates. I was going to review it but it also has too many conflicts now. I am closing it. Happy to review it once the conflicts are resolved @alimeziane.

@MehdiK MehdiK closed this Nov 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants