Fixes trailing question mark reported in #378. #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome. Thanks for the correction and the unit tests. Could you please add this to the release-notes file? |
|
I am glad to help, and thanks for the library! I added the PR to the release notes. |
MehdiK
added a commit
that referenced
this pull request
Feb 12, 2015
Fixes trailing question mark reported in #378.
|
Awesome. Thanks for the addition. |
|
This is now released to NuGet as v1.34.0. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few new tests demonstrate the problem and the fix.
The problem is the upfront single-character check, which lets a single special character through.
The fix is to let the Regex work on every string, and check for empty Enumerations with String.Join and the final ternary operator.