Fixes the IConvertible warning thrown on Windows Phone reported on #317 #376
Conversation
|
@pombeirp can you please clone this branch, build and reference it in your project to see if it removes your last warning? If you can verify this, I will then merge and release this. Thanks. |
|
@MehdiK I've tested it and it fixed the warning. Thanks! |
| @@ -94,7 +94,7 @@ public void HoursFromNowNotTomorrow(int hours, string expected) | |||
| [Theory] | |||
| [InlineData(1, "yesterday")] | |||
| [InlineData(10, "10 days ago")] | |||
| [InlineData(28, "28 days ago")] | |||
| [InlineData(27, "27 days ago")] | |||
There was a problem hiding this comment.
Why this change? Oh, let me guess cause it's February?
There was a problem hiding this comment.
Thanks for the review. Yes, you're right. Suddenly the unit tests started failing!! Do'h!
MehdiK
force-pushed
the
fix-IConvertible-warning
branch
from
7b44bac to
4c1dfd8
Compare
MehdiK
force-pushed
the
fix-IConvertible-warning
branch
from
4c1dfd8 to
f807583
Compare
Fixes the IConvertible warning thrown on Windows Phone reported on #317
|
Thanks for checking @pombeirp. This is now released to NuGet. Please give it a try and see if you're all green! |
|
@MehdiK Confirmed. Thanks for working through this with me, got it compiling again out-of-the-box with no warnings. Awesome! |
|
Awesome. That took quite a few shots but I'm glad it's finally sorted. Thanks for your patience and help on this. |
No description provided.