Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added irregular plural for 'criterion' (it is 'criteria') #361

Closed
wants to merge 2 commits into from
Closed

Added irregular plural for 'criterion' (it is 'criteria') #361

wants to merge 2 commits into from

Conversation

gabrielweyer
Copy link
Contributor

fixes #331

@MehdiK
Copy link
Member

MehdiK commented Dec 15, 2014

Please add a unit test for your change. Thanks

@gabrielweyer
Copy link
Contributor Author

The test in InflectorTests.cs is not enough? I couldn't find any other test testing Pluralize.

@MehdiK
Copy link
Member

MehdiK commented Dec 15, 2014

Ah. Ignore me. I completely overlooked that. That's cool. Thanks. Merged.

@gabrielweyer
Copy link
Contributor Author

No worries 😌

@gabrielweyer gabrielweyer deleted the Fix-plural-of-criterion branch December 16, 2014 08:22
@MehdiK
Copy link
Member

MehdiK commented Dec 18, 2014

Thanks for the contribution. This is now available on NuGet as v1.32.

Borzoo pushed a commit to Borzoo/Humanizer that referenced this pull request Dec 23, 2014
Borzoo pushed a commit to Borzoo/Humanizer that referenced this pull request Dec 23, 2014
Borzoo pushed a commit to Borzoo/Humanizer that referenced this pull request Dec 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The plural of 'criterion' is 'criteria'
2 participants