Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed één to 1 for dutch language #347

Closed
wants to merge 2 commits into from
Closed

Conversation

Yustie
Copy link
Contributor

@Yustie Yustie commented Oct 29, 2014

No description provided.

@MehdiK
Copy link
Member

MehdiK commented Oct 29, 2014

You can check the unit tests on the above Merge pane. It shows the details of CI run with test results. This PR still has one broken test. You don't need to submit a new PR for it though. Just fix it on this PR.

Also add your PR to the release-notes file.

@Yustie
Copy link
Contributor Author

Yustie commented Nov 5, 2014

Done

@MehdiK
Copy link
Member

MehdiK commented Nov 7, 2014

Merged. Thanks.

@MehdiK MehdiK closed this Nov 7, 2014
@MehdiK MehdiK mentioned this pull request Nov 7, 2014
@janv8000
Copy link
Contributor

@Yustie : why did you choose to use the numeric value for 1? Isn't 'één' or 'een' more 'Human'? :)

@Yustie
Copy link
Contributor Author

Yustie commented Nov 17, 2014

@janv8000 because in my application it is necessary to divide the time in more than one 'piece'. For example, 30 hours in my app will be displayed like 1 day, 6 hours, in stead of één dag 6 uur.

However, I did asked to make this configurable, but MehdiK wanted this consistency.
Read my original post here about this: #336

To answer your question which is more human, IMHO it's a matter of taste and how long you need to think when reading a (single) number expressed in digit (excluding "combined" numbers like dates).

@MehdiK
Copy link
Member

MehdiK commented Nov 18, 2014

I don't think either is better than the other; but other language implementations seem to have favored numeric value for 1 which is why I suggested to change it to 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants