Add resource file for Vietnamese language. #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for removing the unneeded file and fixing the build. Please add the required unit tests and also add your PR to the release-notes file. More info on contribution guideline. |
|
done. |
| [InlineData(1299630020, 3, "2 tuần, 1 ngày, 1 giờ")] | ||
| [InlineData(1299630020, 4, "2 tuần, 1 ngày, 1 giờ, 30 giây")] | ||
| [InlineData(1299630020, 5, "2 tuần, 1 ngày, 1 giờ, 30 giây, 20 phần ngàn giây")] | ||
| public void TimeSpanWithPrecesion(int milliseconds, int precesion, string expected) |
There was a problem hiding this comment.
This trips everyone up. You don't need to unit test these: if you're using testing every time unit in isolation, the combination is tested under English tests and will work. I will take them out.
|
Merged. Thanks. |
|
This is now released to NuGet as v1.26.1. Thanks for the addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add resource file for Vietnamese language.