Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slovenian number to words. #247

Closed
wants to merge 6 commits into from

Conversation

MitjaBezensek
Copy link
Contributor

No description provided.

@@ -0,0 +1,81 @@
using System.Collections.Generic;

namespace Humanizer.Localisation.NumberToWords {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format the code so the curlies are on new lines

@MehdiK
Copy link
Member

MehdiK commented Apr 26, 2014

You have a few failing tests. You may check out the TeamCity notification for more details.

@MitjaBezensek
Copy link
Contributor Author

Fixed the code style issues.

Also checked Team City. Seems like there are some problems with Slovenian special characters on the CI server:
Expected: tisoc sto dvanajst
Actual: tisoŠ sto dvanajst

This is the line of code from the test

[InlineData(1112, "tisoč sto dvanajst")]

Interestingly the tests I added before for DataHumanizeTests also have the same character but it works fine there.

@hazzik
Copy link
Member

hazzik commented Apr 26, 2014

Probably the problem with file encoding, please save localisation-aware
files as UTF-8 with BOM

@MitjaBezensek
Copy link
Contributor Author

That seemed to work, thanks for the info! Had to save the file from notepad++, I couldn't get it to work from Visual Studio.

MehdiK pushed a commit that referenced this pull request Apr 27, 2014
@MehdiK
Copy link
Member

MehdiK commented Apr 27, 2014

Thanks guys. Merged now!

@MehdiK MehdiK closed this Apr 27, 2014
@MehdiK
Copy link
Member

MehdiK commented Apr 27, 2014

This is now available on NuGet as v1.25.4.

@MitjaBezensek MitjaBezensek deleted the slovenian branch August 4, 2014 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants