Made Configurator.FormatterFactories public #227
Conversation
justin-edwards
changed the title
|
Thanks for this. That would be it although after seeing your PR, I had some more thoughts about this issue. Please check out #150 and tell us what you think. |
| @@ -1,6 +1,7 @@ | |||
| ###In Development | |||
| - [#217](https://github.com/Mehdik/Humanizer/pull/217): Changed OrdinalizeExtensions to better accommodate localisations. Added pt-BR and Spanish Ordinalize localisation. | |||
| - [#221](https://github.com/Mehdik/Humanizer/pull/221): Added Russian ordinalizer | |||
| - [#227](https://github.com/MehdiK/Humanizer/pull/227): Allowed for public access to Converter, Formatter, and Ordinalizer factories via Configurator. Changed default factories to use lazy loaded Converters, Formatters, and Ordinalizer rather than creating a new instance each time one is requested. | |||
There was a problem hiding this comment.
You seem to be a fair few commits behind upstream. Please fetch and rebase.
|
Great effort @justin-edwards. Thanks for the hard work. In general I quite like where this PR is headed; but there are a few things which I think should change which I have commented on. I'd appreciate if you could please address these issues. Thanks a lot. |
|
|
||
| namespace Humanizer.Configuration | ||
| { | ||
| public class ConverterFactoryCollection |
There was a problem hiding this comment.
Why is it called "XXCollection"? It does not implement "collection" interfaces, so It is against .NET Fx naming convention.
There was a problem hiding this comment.
Completely agree and I guess that I forgot to include that in my comment. I'm really not happy with that naming but I couldn't come up with anything better at the moment. Do you have another suggestion?
… via Configurator, and made the default factories lazy loaded
…l classes and properties
|
I thought it'd be easier to talk over the code so I just created a new PR based on this (#243) with a few changes to the signature and naming of factories. Could you please review and let me know what you think? |
|
Closing since this is wrapped into #243 |
|
Thanks for the great work and for closing this. |
|
This is now available on NuGet as v1.25.4. |
Unless I'm mistaken this is all that's necessary to resolve #150