Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add french localisation for NumberToWords #190

Closed
wants to merge 1 commit into from
Closed

Add french localisation for NumberToWords #190

wants to merge 1 commit into from

Conversation

Tradioyes
Copy link
Contributor

  • Added french (fr-FR) localisation & tests for NumberToWords
  • Localized NumberToOrdinalWordsExtension, NumberToOrdinalWordsTests and
    DateTimeHumanizePrecisionStrategyTests

Added french (fr-FR) localisation & tests for NumberToWords
Localized NumberToOrdinalWordsExtension, NumberToOrdinalWordsTests and
DateTimeHumanizePrecisionStrategyTests
@Tradioyes
Copy link
Contributor Author

I hope I did it right this time ^^
This is based on the more widely used spelling pre-1990 reform.

@thunsaker
Copy link
Contributor

Are the "newer" forms (septante, nonante) used elsewhere, say in Belgium or Canada? Might we need a region check within the ToWords methods to account for these situations? I don't think they warrant a completely separate translation.

@thunsaker
Copy link
Contributor

@Tradioyes also, would you feel comfortable adding those? Should someone from those regions localize the items mentioned?

@Tradioyes
Copy link
Contributor Author

Septante and nonante are both used in fr-BE and fr-CH, octante is fr-CH only I think. These are not the newer forms, but country-specific.
I thought about those while doing mine, but as I'm not sure of other differences besides septante, octante and nonante, I just added fr-FR. I agree with you that they probably don't warrant another translation.
Again, these are not pre or post 1990 differences (french is just weird, and numbers are probably the simpler part).
The post 1990 reforrms basically added hyphens everywhere to composed numbers greater than 100, and it looks weird to most people. Per french academy standard, both hyphenated and non-hyphenated spellings are correct though (source).

@Tradioyes
Copy link
Contributor Author

I just discovered that octante is belgian while huitante is swiss. Someone more comfortable than me with those variations should definitely do it ^^

@thunsaker
Copy link
Contributor

In my brief study of French I was thrown by the counting after you get to soixante, I knew there were more Anglicized versions of seventy and such, but wow, regional differences, no wonder there are hundreds of ISO language codes.

@MehdiK
Copy link
Member

MehdiK commented Apr 12, 2014

Cool. Thanks for this. I made a few changes on your code, rebased, merged and pushed up. Please review my changes here.

For future contribution please check out the contribution guideline here.

@MehdiK MehdiK closed this Apr 12, 2014
@Tradioyes
Copy link
Contributor Author

Great, thanks!

@MehdiK
Copy link
Member

MehdiK commented Apr 12, 2014

This is now published to NuGet as v1.21.1. Thanks.

@Tradioyes Tradioyes deleted the fr-NumberToWords branch April 13, 2014 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants