Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hungarian localization and tests #179

Closed
wants to merge 12 commits into from
Closed

Conversation

gyurisc
Copy link
Contributor

@gyurisc gyurisc commented Apr 11, 2014

Created the resource file and date, timespan for Hungarian locale. Please, review it and let me know if anything needs to be changed

}

[Theory]
[InlineData(0, 3, "nincs idő")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this test. This has been covered by the English test and the tests you wrote above.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is still here! o_O

@MehdiK
Copy link
Member

MehdiK commented Apr 11, 2014

Thanks for the great contribution. Please fix the comments and also go through this checklist as there are a few things you've missed.

Please leave me a comment here when you're done so I can check it out and merge.

@gyurisc
Copy link
Contributor Author

gyurisc commented Apr 11, 2014

I hopefully fixed all the problems with the tests. I went through the checklist and I also updated the release notes. I do not have resharper, so I am not sure if there are any warnings or not. Please, review the change and let me know, if anything else is needed.

}

[Theory]
[InlineData(135, "2 perc")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for 135 and 60

@MehdiK
Copy link
Member

MehdiK commented Apr 11, 2014

Thanks for the fixes. I left a few comments. No worries about R#.

@gyurisc
Copy link
Contributor Author

gyurisc commented Apr 12, 2014

I rebased the git repo (never did this before) and removed the tests. Fingers crossed :)

@MehdiK
Copy link
Member

MehdiK commented Apr 12, 2014

I rebased your work, made a few changes and pushed up. Thanks.

@MehdiK MehdiK closed this Apr 12, 2014
@MehdiK
Copy link
Member

MehdiK commented Apr 12, 2014

This is now published to NuGet as v1.21.1. Thanks.

@LBobirca
Copy link

LBobirca commented Apr 10, 2019

Any change we can get a numbers to words for Hungarian? I have a need for it in writing out check amounts in multiple languages, one of which is Hungarian.

@gyurisc
Copy link
Contributor Author

gyurisc commented Apr 11, 2019

@LBobirca Can you please describe the problem with the numbers to words in Hungarian? I did the original work for the Hungarian localization and I would help you fix this issue if I have a good understanding of what the problem is. Thanks, Krisztian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants