Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add russian translation for time spans #143

Merged
merged 4 commits into from
Apr 9, 2014
Merged

Conversation

mexx
Copy link
Collaborator

@mexx mexx commented Apr 9, 2014

No description provided.

@MehdiK
Copy link
Member

MehdiK commented Apr 9, 2014

Thanks for this. Just a few things:

  • Could you please also add future DateTime support (with tests); e.g. SecondsFromNow?
  • Please also add your PR to the release-notes file (to in development section).

@mexx
Copy link
Collaborator Author

mexx commented Apr 9, 2014

Future DateTime, yes I'm currently on it.

@mexx
Copy link
Collaborator Author

mexx commented Apr 9, 2014

Ok, now russian translation should be complete.

MehdiK added a commit that referenced this pull request Apr 9, 2014
add russian translation for time spans
@MehdiK MehdiK merged commit 2480330 into Humanizr:master Apr 9, 2014
@MehdiK
Copy link
Member

MehdiK commented Apr 9, 2014

Thanks for the great contribution. I really wanted the Russian localisation to be improved and completed and you did very well.

P.S. You can also localize ToWords method :) There is no easy way out of that though and it has to be implemented from scratch. Check out the ToWords class.

@mexx
Copy link
Collaborator Author

mexx commented Apr 9, 2014

Done with #147

@MehdiK
Copy link
Member

MehdiK commented Apr 10, 2014

Thanks for your great contribution. This is now released to NuGet as v1.19.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants