Initial Indonesia localization #141
Conversation
| @@ -6,6 +6,7 @@ | |||
| - [#137](https://github.com/MehdiK/Humanizer/pull/137): Fixed grammar error in `nb-NO` resource file & added missing Norwegian resource strings (mainly `DateHumanize_*FromNow`) | |||
| - [#135](https://github.com/MehdiK/Humanizer/pull/135): Added Swedish localization (strings, tests) | |||
| - [#140](https://github.com/MehdiK/Humanizer/pull/140): Added Polish localization (strings, formatter, tests) | |||
| - [#141](https://github.com/MehdiK/Humanizer/pull/141): Added Indonesia localization (strings, tests) | |||
There was a problem hiding this comment.
v1.18.1 is already released. Please move this to the in development section.
|
Thanks for writing the clean code with tests & release notes entry. I wrote a few comments on your code. |
|
I will update as your note. thanks for the feedback. |
|
On progress at implementation NumberToWords |
|
Sorry wrong button press :( |
| public TimeSpanHumanizeTests() : base("id-ID") { } | ||
|
|
||
| [Theory] | ||
| [InlineData(7, "1 minggu")] |
There was a problem hiding this comment.
Please add test cases for multiple units for TimeSpan too; e.g. 2 weeks.
|
Can you leave NumberToWords for a separate PR? Please rebase your work on top of the latest on upstream. |
|
Sure, i am removed the NumberToWords for this PR. :) |
Base on default Resource.
|
I rebased your commits and made a few changes. The problem is that I had to change the date time and timespan tests and I have no idea about Indonasian. Please review my changes here. |
|
This is now published to NuGet as v1.21.1. Thanks. |
Base on default Resource.