Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant ToQuantity asserts #1384

Merged
merged 1 commit into from
Feb 16, 2024
Merged

remove redundant ToQuantity asserts #1384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 6 additions & 23 deletions src/Humanizer.Tests.Shared/ToQuantityTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,8 @@ public class ToQuantityTests
[InlineData("slice", 2, "2 slices")]
[InlineData("slices", 1, "1 slice")]
[InlineData("slices", 2, "2 slices")]
public void ToQuantity(string word, int quantity, string expected)
{
public void ToQuantity(string word, int quantity, string expected) =>
Assert.Equal(expected, word.ToQuantity(quantity));
Assert.Equal(expected, word.ToQuantity((long)quantity));
}

[Theory]
[InlineData("case", 0, "cases")]
Expand All @@ -37,11 +34,8 @@ public void ToQuantity(string word, int quantity, string expected)
[InlineData("process", 1, "process")]
[InlineData("processes", 2, "processes")]
[InlineData("processes", 1, "process")]
public void ToQuantityWithNoQuantity(string word, int quantity, string expected)
{
public void ToQuantityWithNoQuantity(string word, int quantity, string expected) =>
Assert.Equal(expected, word.ToQuantity(quantity, ShowQuantityAs.None));
Assert.Equal(expected, word.ToQuantity((long)quantity, ShowQuantityAs.None));
}

[Theory]
[InlineData("case", 0, "0 cases")]
Expand All @@ -55,12 +49,8 @@ public void ToQuantityWithNoQuantity(string word, int quantity, string expected)
[InlineData("process", 1, "1 process")]
[InlineData("processes", 2, "2 processes")]
[InlineData("processes", 1, "1 process")]
public void ToQuantityNumeric(string word, int quantity, string expected)
{
// ReSharper disable once RedundantArgumentDefaultValue
Assert.Equal(expected, word.ToQuantity(quantity, ShowQuantityAs.Numeric));
Assert.Equal(expected, word.ToQuantity((long)quantity, ShowQuantityAs.Numeric));
}
public void ToQuantityNumeric(string word, int quantity, string expected) =>
Assert.Equal(expected, word.ToQuantity(quantity));

[Theory]
[InlineData("hour", 1, "1 hour")]
Expand All @@ -83,11 +73,8 @@ public void ToDoubleQuantityNumeric(string word, double quantity, string expecte
[InlineData("processes", 2, "two processes")]
[InlineData("processes", 1200, "one thousand two hundred processes")]
[InlineData("processes", 1, "one process")]
public void ToQuantityWords(string word, int quantity, string expected)
{
public void ToQuantityWords(string word, int quantity, string expected) =>
Assert.Equal(expected, word.ToQuantity(quantity, ShowQuantityAs.Words));
Assert.Equal(expected, word.ToQuantity((long)quantity, ShowQuantityAs.Words));
}

[Theory]
[InlineData("case", 0, null, "0 cases")]
Expand All @@ -101,11 +88,8 @@ public void ToQuantityWords(string word, int quantity, string expected)
[InlineData("dollar", 1, "C0", "$1 dollar")]
[InlineData("dollar", 2, "C0", "$2 dollars")]
[InlineData("dollar", 2, "C2", "$2.00 dollars")]
public void ToQuantityWordsWithCurrentCultureFormatting(string word, int quantity, string format, string expected)
{
public void ToQuantityWordsWithCurrentCultureFormatting(string word, int quantity, string format, string expected) =>
Assert.Equal(expected, word.ToQuantity(quantity, format));
Assert.Equal(expected, word.ToQuantity((long)quantity, format));
}

[Theory]
[InlineData("case", 0, "N0", "it-IT", "0 cases")]
Expand All @@ -122,7 +106,6 @@ public void ToQuantityWordsWithCustomCultureFormatting(string word, int quantity
var culture = new CultureInfo(cultureCode);

Assert.Equal(expected, word.ToQuantity(quantity, format, culture), GetStringComparer(culture));
Assert.Equal(expected, word.ToQuantity((long)quantity, format, culture), GetStringComparer(culture));
}

internal static StringComparer GetStringComparer(CultureInfo culture) =>
Expand Down