Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the greek B (Beta) char to a regular B in method #1246

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

vilinet
Copy link
Contributor

@vilinet vilinet commented Dec 12, 2022

Fixes a character encoding problem, related to a 'B' char in a method. See the details in the related ticket: #1245

This PR simply replaces that special B char to a regular B char.

…thods as very latest visual studio is more sensitive somehow to character encodings
@dnfadmin
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ vilinet sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@AmrAlSayed0
Copy link

Please accept this PR, this issue is causing the AOT compiler to fail

7>  [aot-compiler stderr] obj\\Release\\130\\aot\\armeabi-v7a\\Humanizer.dll\\temp.s:2441:84: error: unexpected token in argument list (TaskId:1658)
7>  [aot-compiler stderr] ldr pc,=Humanizer_Localisation_NumberToWords_GreekNumberToWordsConverter_ConvertInt╬_13_long_bool (TaskId:1658)
7>  [aot-compiler stderr] obj\\Release\\130\\aot\\armeabi-v7a\\Humanizer.dll\\temp.s:7603:86: error: unexpected token in operand (TaskId:1658)
7>  [aot-compiler stderr] p_375_plt_Humanizer_Localisation_NumberToWords_GreekNumberToWordsConverter_ConvertInt╬_13_long_bool_llvm: (TaskId:1658)
7>  [aot-compiler stderr] obj\\Release\\130\\aot\\armeabi-v7a\\Humanizer.dll\\temp.s:7604:94: error: unexpected token (TaskId:1658)
7>  [aot-compiler stderr]         .globl p_375_plt_Humanizer_Localisation_NumberToWords_GreekNumberToWordsConverter_ConvertInt╬_13_long_bool_llvm (TaskId:1658)
7>  [aot-compiler stderr] obj\\Release\\130\\aot\\armeabi-v7a\\Humanizer.dll\\temp.s:7605:93: error: expected STT_<TYPE_IN_UPPER_CASE>, '#<type>', '%<type>' or "<type>" (TaskId:1658)
7>  [aot-compiler stderr]         .type p_375_plt_Humanizer_Localisation_NumberToWords_GreekNumberToWordsConverter_ConvertInt╬_13_long_bool_llvm,#function (TaskId:1658)
7>  [aot-compiler stderr] obj\\Release\\130\\aot\\armeabi-v7a\\Humanizer.dll\\temp.s:7606:88: error: unexpected token in directive (TaskId:1658)
7>  [aot-compiler stderr]         .local plt_Humanizer_Localisation_NumberToWords_GreekNumberToWordsConverter_ConvertInt╬_13_long_bool (TaskId:1658)
7>  [aot-compiler stderr] obj\\Release\\130\\aot\\armeabi-v7a\\Humanizer.dll\\temp.s:7607:87: error: expected STT_<TYPE_IN_UPPER_CASE>, '#<type>', '%<type>' or "<type>" (TaskId:1658)
7>  [aot-compiler stderr]         .type plt_Humanizer_Localisation_NumberToWords_GreekNumberToWordsConverter_ConvertInt╬_13_long_bool,#function (TaskId:1658)
7>  [aot-compiler stderr] obj\\Release\\130\\aot\\armeabi-v7a\\Humanizer.dll\\temp.s:7608:80: error: unexpected token in operand (TaskId:1658)
7>  [aot-compiler stderr] plt_Humanizer_Localisation_NumberToWords_GreekNumberToWordsConverter_ConvertInt╬_13_long_bool: (TaskId:1658)
7>  [aot-compiler stderr] obj\\Release\\130\\aot\\armeabi-v7a\\Humanizer.dll\\temp.s:7613:87: error: unexpected token in directive (TaskId:1658)
7>  [aot-compiler stderr]         .size plt_Humanizer_Localisation_NumberToWords_GreekNumberToWordsConverter_ConvertInt╬_13_long_bool,.-plt_Humanizer_Localisation_NumberToWords_GreekNumberToWordsConverter_ConvertInt╬_13_long_bool (TaskId:1658)
7>  [aot-compiler stdout] Running: "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\MSBuild\\Xamarin\\Android\\binutils\\bin\\llvm-mc.exe" --arch=arm --triple=arm-linux-gnu --assemble --filetype=obj --mattr=+armv7-a,+vfp3 -o=obj\Release\130\aot\armeabi-v7a\Humanizer.dll\temp.s.o obj\Release\130\aot\armeabi-v7a\Humanizer.dll\temp.s (TaskId:1658)
7>  [aot-compiler stdout] Running: "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\MSBuild\\Xamarin\\Android\\binutils\\bin\\llvm-mc.exe" --arch=arm --triple=arm-linux-gnu --assemble --filetype=obj --mattr=+armv7-a,+vfp3 -o=obj\Release\130\aot\armeabi-v7a\Humanizer.dll\temp-llvm.o obj\Release\130\aot\armeabi-v7a\Humanizer.dll\temp-llvm.s (TaskId:1658)
7>  [aot-compiler stderr] ld: error: cannot open obj\Release\130\aot\armeabi-v7a\Humanizer.dll\temp.s.o: no such file or directory (TaskId:1658)
7>  [aot-compiler stderr] C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Xamarin\Android\binutils\bin\llvm-strip.exe: error: 'obj\Release\130\aot\armeabi-v7a\libaot-Humanizer.dll.so.tmp': no such file or directory (TaskId:1658)

@hazzik hazzik closed this May 15, 2023
@hazzik hazzik reopened this May 15, 2023
@vilinet
Copy link
Contributor Author

vilinet commented Jun 16, 2023

@dotnet-policy-service agree

@dotnet-policy-service agree

@SimonCropp
Copy link
Collaborator

thanks for the contribution

@SimonCropp SimonCropp merged commit 7491330 into Humanizr:main Feb 12, 2024
@SimonCropp SimonCropp added this to the v3.0 milestone Feb 12, 2024
@SimonCropp SimonCropp changed the title #1245: Replace the greek B (Beta) char to a regular B in method Replace the greek B (Beta) char to a regular B in method Feb 22, 2024
@SimonCropp SimonCropp added the bug label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants