Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

special case for letter 's' #1178

Merged
merged 2 commits into from
Mar 1, 2022

Conversation

neilboyd
Copy link
Contributor

@neilboyd neilboyd commented Feb 17, 2022

Handle singularizing and pluralizing of letter 's'.

It is not sufficient to just handle singularizing of single letter words because letter 's' has a special meaning when singularizing and pluralizing.

Fixes #1154


Here is a checklist you should tick through before submitting a pull request:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No Code Analysis warnings
  • There is proper unit test coverage
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • Xml documentation is added/updated for the addition/change
  • Your PR is (re)based on top of the latest commits from the main branch (more info below)
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one
  • Run either build.cmd or build.ps1 and ensure there are no test failures

@@ -280,6 +280,7 @@ public IEnumerator<object[]> GetEnumerator()
yield return new object[] { "alumna", "alumnae" };
yield return new object[] { "alumnus", "alumni" };
yield return new object[] { "fungus", "fungi" };

Copy link
Contributor Author

@neilboyd neilboyd Feb 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank line here because this is where the original file stopped.

@neilboyd neilboyd force-pushed the singularize-single-letter branch from 11261c7 to e8c446a Compare February 18, 2022 15:48
@neilboyd neilboyd force-pushed the singularize-single-letter branch from e8c446a to 12e0593 Compare February 20, 2022 14:10
@neilboyd neilboyd changed the title test cases for single letter special case for letter s Feb 20, 2022
@neilboyd neilboyd changed the title special case for letter s special case for letter 's' Feb 20, 2022
@neilboyd neilboyd marked this pull request as ready for review February 20, 2022 15:56
@clairernovotny clairernovotny merged commit 6374139 into Humanizr:main Mar 1, 2022
@neilboyd neilboyd deleted the singularize-single-letter branch March 1, 2022 20:16
@0xced 0xced mentioned this pull request Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Index out of range during Singularize
2 participants