Use VSBuild instead of dotnet build #1177
Conversation
|
Can you please open an issue on the pipelines repo so this can be tracked and fixed? |
@clairernovotny Which repo is that? |
|
The problem is not with the build agent. I've narrowed it down a bit and updated the description. |
|
I'm definitely not skipping tests. There may be a bug somewhere in the cli though that should be filed: https://github.com/microsoft/vstest |
|
Hello @neilboyd, I am not entirely sure why this is happening. I added a test case to [Fact]
[UseCulture("ku")]
public void CanGetCultureSpecificTranslationsWithImplicitCultureKurdish()
{
var format = Resources.GetResource("DateHumanize_MultipleYearsAgo");
Assert.Equal("{0} ساڵ لەمەوبەر", format);
}When I build using CLI: Meanwhile when I build using VS 2022: I am not sure why, but for some reason, when the solution is built using the CLI, the tests can't find Kurdish resources. One thing I can think of is on Windows Central Kurdish culture's eventual code is |
|
@clairernovotny I obviously wasn't suggesting to permanently skip the tests. That's why I put the PR back to draft until I could figure it out. I was just checking if this is the only reason the build is failing on @mhmd-azeez Thanks for confirming the behavior I saw. I tried using |
|
In Powershell, if I run |
|
If you run that in the windows-2019 agent, what does it return there? I'm trying to find a definitive source for what the locale code should be here and am struggling. |
|
The tests succeed on the I'm trying to find the source of the issue. I don't think it's the build agent, or even dotnet cli, because they're just platforms for running other stuff. What's also weird is that the failing tests depend on how it's built:
So that tells me that it's something to do with the dotnet cli build. Not the test runner, and not the installed locales. |
|
Looks like we're hitting this issue: dotnet/msbuild#3897 that affects builds on .NET 6. Building in VS works because it's using .NET Framework. |
|
So using That seems to be an acceptable solution: |
Yes, it looks like it. That issue is also referenced by dotnet/msbuild#7331 |
neilboyd
changed the title
|
@clairernovotny how do you want to proceed with this? Until something is done no-one can build any PRs. I would suggest the following:
|
|
I'm still not sure if we need both |
The CI build started failing when Windows 2022 became the
windows-latestbuild agent.This is because of an issue that was causing Kurdish locale tests to fail.
This PR uses the
VSBuildtask instead ofdotnet buildin order to mitigate the issue.Here is a checklist you should tick through before submitting a pull request:
mainbranch (more info below)fixes #<the issue number>build.cmdorbuild.ps1and ensure there are no test failures