Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add French support when using toWords: true in TimeSpan humanization #1025

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

0xced
Copy link
Contributor

@0xced 0xced commented Jan 12, 2021

Also removed [Trait("Translation", "Google")] from TimeSpanHumanizeTests after review. (I assumed that the trait means that the translation were automatically generated by Google vs manually written by a human)

Also removed [Trait("Translation", "Google")] from TimeSpanHumanizeTests after  review. (I assumed that the trait means that the translation were automatically generated by Google vs manually written by a human)
@aloisdg
Copy link
Contributor

aloisdg commented Mar 21, 2021

French here. Everything looks good :)

@clairernovotny clairernovotny merged commit 1f0f74e into Humanizr:main Apr 23, 2021
@0xced 0xced deleted the TimeSpan_ToWords_French branch April 23, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants