Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"slice".ToQuantity(1) results in "1 slouse" #908

Closed
Eric341 opened this issue Mar 9, 2020 · 1 comment
Closed

"slice".ToQuantity(1) results in "1 slouse" #908

Eric341 opened this issue Mar 9, 2020 · 1 comment

Comments

@Eric341
Copy link

Eric341 commented Mar 9, 2020

There is a default pluralize, singularize in dictionary that cause undesired results.
@AKTheKnight
Copy link
Contributor

Hi, thanks for reporting this.

I've made a PR to fix it and hopefully it can be merged and released soon :)

@hazzik hazzik closed this as completed in e33e81a Mar 18, 2020
jvanrhyn pushed a commit to jvanrhyn/Humanizer that referenced this issue Sep 10, 2020
@AKTheKnight @jvanrhyn
Fix Humanizr#908
d7d9e89 
Just changes *ice and *ouse to only match the one letter before we have listed. Not all. (Without the ^ it would match slice and slouse)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AKTheKnight @Eric341