-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A collection formatter for the current culture has not been implemented yet #392
Comments
Thanks for reporting the issue. It must be related to #386. On reviewing I thought that PR was backward compatible; but apparently I was wrong. What's the current culture you're using? |
is the culture set on spanish by chrome. In cultureInfo it prints ES as the culture. hope it helps. Let me know if you need to do something on my end. I'm more than happy to help. |
The problem with the collection formatter is the default implementation, which throws an exception. I had the same issue in German and Danish. This is why I came up with the generalization in my pull request. I will create a pull request for that and the decision is up to MehdiK. |
Thanks for the PR @ThomasMentzel. I like it. We left you a couple of comments on it. I'm still wondering why it wasn't failing before and only it started failing after #386!! |
…tes it in regular style with "&" as separator. in already implemented languages, it returns the language specific translation for "and". #392
This is now fixed by @ThomasMentzel and available on NuGet as v1.35.0. Thanks for reporting. |
Meant to be closed |
I'm pretty sure this code worked before (data may be different, but still)
var a = new DateTime[] { DateTime.UtcNow, DateTime.UtcNow.AddDays(10) };
var b = a.Humanize(); // THROWS!
A collection formatter for the current culture has not been implemented yet.
I'm not sure what I'm looking into. any help is appreciated.
The text was updated successfully, but these errors were encountered: