-
Notifications
You must be signed in to change notification settings - Fork 967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IFormatter.TimeSpanHumanize for TimeUnits larger than TimeUnit.Week #270
Comments
Correct. That's the expected behavior because you wouldn't know how many days go into a month (and the same is true for years considering the leap years). Why do you need to call that directly though? |
Considering it's a public method it should throw a more meaningful exception I think. |
Good point. I don't think it should be public. |
As mentioned in #275 I now think that we can't just change the access modifiers as there is a chance people are using this, and in fact I now think it's useful to have these as public. I guess what we need is to tidy up the exception if necessary. |
It throws an exception as there is no resource key defined for these units.
The text was updated successfully, but these errors were encountered: