Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IFormatter.TimeSpanHumanize for TimeUnits larger than TimeUnit.Week #270

Closed
Borzoo opened this issue May 20, 2014 · 5 comments
Closed

IFormatter.TimeSpanHumanize for TimeUnits larger than TimeUnit.Week #270

Borzoo opened this issue May 20, 2014 · 5 comments

Comments

@Borzoo
Copy link
Contributor

Borzoo commented May 20, 2014

It throws an exception as there is no resource key defined for these units.

@MehdiK
Copy link
Member

MehdiK commented May 20, 2014

Correct. That's the expected behavior because you wouldn't know how many days go into a month (and the same is true for years considering the leap years).

Why do you need to call that directly though?

@Borzoo
Copy link
Contributor Author

Borzoo commented May 21, 2014

Considering it's a public method it should throw a more meaningful exception I think.

@MehdiK
Copy link
Member

MehdiK commented May 23, 2014

Good point. I don't think it should be public.

Borzoo added a commit to Borzoo/Humanizer that referenced this issue May 23, 2014
@MehdiK
Copy link
Member

MehdiK commented May 23, 2014

As mentioned in #275 I now think that we can't just change the access modifiers as there is a chance people are using this, and in fact I now think it's useful to have these as public. I guess what we need is to tidy up the exception if necessary.

@mexx
Copy link
Collaborator

mexx commented Aug 7, 2014

Closing as #322 is merged with 974fafc

@mexx mexx closed this as completed Aug 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants