Fix typing issue in python 3.9 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernestum
force-pushed
the
typing-fixes-py39
branch
from
02c1355 to
dd73dc8
Compare
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 1096 1089 -7
=========================================
- Hits 1096 1089 -7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ernestum
force-pushed
the
typing-fixes-py39
branch
2 times, most recently
from
d5a0a46 to
7b9fe61
Compare
ernestum
force-pushed
the
typing-fixes-py39
branch
from
7b9fe61 to
d56c50d
Compare
3 tasks
AdamGleave
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one issue with the way the
MaskScoreWrapperuses generics in python 3.9.This PR fixes it.
I could not figure out how to place the type annotations in such a way that it is not tripping the runtime checks in Python 3.9 and pytype at the same time. So I decided to remove them alltogether and inherit from
gym.ObservationWrapperjust likeObsCastWrapper.