-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to gymnasium maintaining python 3.8 compatibility #73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review, @ernestum you may find this helpful. Please request another review once you get tests passing and finished any clean up you wanted to do.
…he documentation.
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 1047 1096 +49
=========================================
+ Hits 1047 1096 +49
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…tead of gym.Wrapper.
…ePOMDP are rejected.
…p_random of the superclass instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There are two unresolved comments but they're not requirements to fix.
Description
Continuing the work in #72
reverted incompatible > python3.9 changes
primarily changes for compatibility with (Gymnasium compatibility maintaining python3.8 imitation#765)
further changes to environments
reset
,step
and random functions.Update to Ubuntu 20.04
Upgraded from the MuJoCo-v3 to the v4 environments bumping their corresponding seals version along the way.
Rename the circleci docker image (remove -beta suffix)
Testing
Some test have been refactored. Mostly the rendering tests.