Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to gymnasium maintaining python 3.8 compatibility #73

Merged
merged 61 commits into from
Aug 31, 2023

Conversation

EdoardoPona
Copy link
Collaborator

@EdoardoPona EdoardoPona commented Jul 28, 2023

Description

Continuing the work in #72

  • reverted incompatible > python3.9 changes

  • primarily changes for compatibility with (Gymnasium compatibility maintaining python3.8  imitation#765)

  • further changes to environments reset, step and random functions.

  • Update to Ubuntu 20.04

  • Upgraded from the MuJoCo-v3 to the v4 environments bumping their corresponding seals version along the way.

  • Rename the circleci docker image (remove -beta suffix)

Testing

Some test have been refactored. Mostly the rendering tests.

@EdoardoPona EdoardoPona linked an issue Jul 28, 2023 that may be closed by this pull request
Copy link
Member

@AdamGleave AdamGleave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review, @ernestum you may find this helpful. Please request another review once you get tests passing and finished any clean up you wanted to do.

README.md Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
src/seals/base_envs.py Outdated Show resolved Hide resolved
src/seals/base_envs.py Outdated Show resolved Hide resolved
src/seals/base_envs.py Outdated Show resolved Hide resolved
src/seals/testing/envs.py Outdated Show resolved Hide resolved
src/seals/util.py Outdated Show resolved Hide resolved
src/seals/util.py Outdated Show resolved Hide resolved
src/seals/util.py Show resolved Hide resolved
src/seals/util.py Outdated Show resolved Hide resolved
@ernestum ernestum self-assigned this Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #73 (1cd4530) into master (dff53ee) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #73   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         1047      1096   +49     
=========================================
+ Hits          1047      1096   +49     
Files Changed Coverage Δ
src/seals/__init__.py 100.00% <100.00%> (ø)
src/seals/atari.py 100.00% <100.00%> (ø)
src/seals/base_envs.py 100.00% <100.00%> (ø)
src/seals/classic_control.py 100.00% <100.00%> (ø)
src/seals/diagnostics/__init__.py 100.00% <100.00%> (ø)
src/seals/diagnostics/early_term.py 100.00% <100.00%> (ø)
src/seals/diagnostics/init_shift.py 100.00% <100.00%> (ø)
src/seals/diagnostics/largest_sum.py 100.00% <100.00%> (ø)
src/seals/diagnostics/noisy_obs.py 100.00% <100.00%> (ø)
src/seals/diagnostics/parabola.py 100.00% <100.00%> (ø)
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ernestum ernestum marked this pull request as ready for review August 15, 2023 12:41
@ernestum ernestum mentioned this pull request Aug 16, 2023
@ernestum ernestum requested a review from Rocamonde August 16, 2023 07:22
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
tests/test_wrappers.py Outdated Show resolved Hide resolved
tests/test_wrappers.py Show resolved Hide resolved
tests/test_util.py Outdated Show resolved Hide resolved
tests/test_envs.py Show resolved Hide resolved
tests/test_base_env.py Show resolved Hide resolved
tests/test_base_env.py Show resolved Hide resolved
@ernestum ernestum requested a review from Rocamonde August 28, 2023 13:02
Copy link
Member

@Rocamonde Rocamonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There are two unresolved comments but they're not requirements to fix.

@ernestum ernestum merged commit a7954c2 into master Aug 31, 2023
@ernestum ernestum deleted the fix71-py38 branch August 31, 2023 14:27
@ernestum ernestum mentioned this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gymnasium compatibility of seals
4 participants