Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change type of horizon from float to int. #66

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Conversation

ianyfan
Copy link
Contributor

@ianyfan ianyfan commented Oct 28, 2022

Or None, for infinite horizon.

This will require extra checks downstream, but is more robust against accidentally providing non-integer horizons.

Or `None`, for infinite horizon.
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #66 (547d5bb) into master (eeb9beb) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #66   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          982       982           
=========================================
  Hits           982       982           
Impacted Files Coverage Δ
src/seals/base_envs.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@AdamGleave AdamGleave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdamGleave AdamGleave merged commit 956fbb4 into master Oct 28, 2022
@AdamGleave AdamGleave deleted the ianyfan/int-horizon branch October 28, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants