Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump node from 12.12.0-alpine to 13.5.0-alpine in /backend #2597

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Dec 20, 2019

Bumps node from 12.12.0-alpine to 13.5.0-alpine.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file docker Pull requests that update Docker code labels Dec 20, 2019
@cypress
Copy link

cypress bot commented Dec 20, 2019



Test summary

49 1 0 0


Run details

Project Human-Connection
Status Failed
Commit 7acd122
Started Dec 20, 2019 1:49 PM
Ended Dec 20, 2019 2:01 PM
Duration 12:30 💡
OS Linux Ubuntu Linux - 16.04
Browser Chromium 79

View run in Cypress Dashboard ➡️


Failures

cypress/integration/user_profile/UploadUserProfileImage.feature Failed
1 Upload UserProfile Image > Change my UserProfile Image

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Bumps node from 12.12.0-alpine to 13.5.0-alpine.

Signed-off-by: dependabot-preview[bot] <[email protected]>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/docker/backend/node-13.5.0-alpine branch from b6fe746 to 301dd50 Compare December 20, 2019 10:38
@mattwr18
Copy link
Member

this is blocked by a deprecated API

this is failing the build because of our file uploads ... here is an error

(node:15833) [DEP0135] DeprecationWarning: ReadStream.prototype.open() is deprecated
we are also getting a Maximum call stack exceeded

After doing some research, this is being thrown by fs-capacitor, which is used by graphql-upload, which is used by apollo-server... thankfully, fs-capacitor can be upgraded with support for node 13, but we need to wait till apollo-server-core updates their package.json with graphql-upload 9.0.0
more info here:
apollographql/apollo-server#3508

Question, that I don't think we have talked about, is if we want to be upgrading our node version to the latest in our production images, since there will certainly be issues to deal with as trailblazers, or if we should keep them versioned to the LTS, which is 12.14.0??
https://nodejs.org/en/

@roschaefer
Copy link
Contributor

@mattwr18 I think you have a point. The nodejs website says:

Production applications should only use Active LTS or Maintenance LTS releases.

So maybe we should pin all our nodejs images to lts-alpine?

I would still like to see those version updates though, so maybe we should start with lts-alpine3.11:
https://hub.docker.com/layers/node/library/node/lts-alpine3.11/images/sha256-ccc95a4262bd49f7a6b0027d8e6844de800230f4c4de36082c097916c56537be

I hope @dependabot-bot is able to update versions along the lts-alpine range?

@dependabot-preview
Copy link
Contributor Author

👋 If you need additional help with Dependabot, please fill out GitHub's Support form and your request will be routed to the right team at GitHub.

Be sure to include the details of any troubleshooting steps you've tried so far.

@dependabot-preview
Copy link
Contributor Author

Superseded by #2710.

@dependabot-preview dependabot-preview bot deleted the dependabot/docker/backend/node-13.5.0-alpine branch January 9, 2020 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants